From 0dd41e48301a774e7b95d2dc687fd2697d524ea1 Mon Sep 17 00:00:00 2001
From: oobabooga <112222186+oobabooga@users.noreply.github.com>
Date: Fri, 17 Feb 2023 16:33:27 -0300
Subject: [PATCH] Reorganize the sliders some more

---
 modules/ui.py |  1 -
 server.py     | 26 ++++++++++++++------------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/modules/ui.py b/modules/ui.py
index b0fbc16..4aefc66 100644
--- a/modules/ui.py
+++ b/modules/ui.py
@@ -26,7 +26,6 @@ css = """
   min-height: 0
 }
 #accordion {
-  background-color: transparent;
 }
 """
 
diff --git a/server.py b/server.py
index 84a4be0..7f4be43 100644
--- a/server.py
+++ b/server.py
@@ -462,23 +462,25 @@ def create_settings_menus():
 
     with gr.Accordion("Custom generation parameters", open=False, elem_id="accordion"):
         with gr.Row():
-            with gr.Column():
-                do_sample = gr.Checkbox(value=generate_params['do_sample'], label="do_sample")
-                temperature = gr.Slider(0.01, 1.99, value=generate_params['temperature'], step=0.01, label="temperature")
-                top_p = gr.Slider(0.0,1.0,value=generate_params['top_p'],step=0.01,label="top_p")
-                typical_p = gr.Slider(0.0,1.0,value=generate_params['typical_p'],step=0.01,label="typical_p")
-            with gr.Column():
-                top_k = gr.Slider(0,200,value=generate_params['top_k'],step=1,label="top_k")
-                repetition_penalty = gr.Slider(1.0,4.99,value=generate_params['repetition_penalty'],step=0.01,label="repetition_penalty")
-                no_repeat_ngram_size = gr.Slider(0, 20, step=1, value=generate_params["no_repeat_ngram_size"], label="no_repeat_ngram_size")
-                min_length = gr.Slider(0, 2000, step=1, value=generate_params["min_length"] if args.no_stream else 0, label="min_length", interactive=args.no_stream)
+            do_sample = gr.Checkbox(value=generate_params['do_sample'], label="do_sample")
+            temperature = gr.Slider(0.01, 1.99, value=generate_params['temperature'], step=0.01, label="temperature")
+        with gr.Row():
+            top_k = gr.Slider(0,200,value=generate_params['top_k'],step=1,label="top_k")
+            top_p = gr.Slider(0.0,1.0,value=generate_params['top_p'],step=0.01,label="top_p")
+        with gr.Row():
+            repetition_penalty = gr.Slider(1.0,4.99,value=generate_params['repetition_penalty'],step=0.01,label="repetition_penalty")
+            no_repeat_ngram_size = gr.Slider(0, 20, step=1, value=generate_params["no_repeat_ngram_size"], label="no_repeat_ngram_size")
+        with gr.Row():
+            typical_p = gr.Slider(0.0,1.0,value=generate_params['typical_p'],step=0.01,label="typical_p")
+            min_length = gr.Slider(0, 2000, step=1, value=generate_params["min_length"] if args.no_stream else 0, label="min_length", interactive=args.no_stream)
 
         gr.Markdown("Contrastive search:")
         penalty_alpha = gr.Slider(0, 5, value=generate_params["penalty_alpha"], label="penalty_alpha")
 
         gr.Markdown("Beam search (uses a lot of VRAM):")
-        num_beams = gr.Slider(1, 20, step=1, value=generate_params["num_beams"], label="num_beams")
-        length_penalty = gr.Slider(-5, 5, value=generate_params["length_penalty"], label="length_penalty")
+        with gr.Row():
+            num_beams = gr.Slider(1, 20, step=1, value=generate_params["num_beams"], label="num_beams")
+            length_penalty = gr.Slider(-5, 5, value=generate_params["length_penalty"], label="length_penalty")
         early_stopping = gr.Checkbox(value=generate_params["early_stopping"], label="early_stopping")
 
     with gr.Accordion("Soft prompt", open=False, elem_id="accordion"):